chore(guides): some missing snippets + guides #4477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Fluf22
force-pushed
the
feat/more-generated-guides
branch
from
b338e4a to
f16f483
Compare
millotp
approved these changes
Feb 19, 2025
Contributor
millotp
left a comment
millotp
left a comment
There was a problem hiding this comment.
huuuuuuge ! thanks a lot for doing this !
|
|
||
| self.wait_task_time_before_retry: Optional[int] = None | ||
| self.headers: Optional[Dict[str, str]] = None | ||
| self.headers: Dict[str, str] = {} |
Collaborator
Author
There was a problem hiding this comment.
Because ultimately we always use it as a dict, it's never treated like it can be None
So setting it to an empty dict from the beginning ease the DX
algolia-bot
added a commit
that referenced
this pull request
Feb 19, 2025
…ip ci] Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Feb 19, 2025
algolia/api-clients-automation#4477 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: DI-3413
Changes included: